• Stars
    star
    415
  • Rank 100,465 (Top 3 %)
  • Language
    Erlang
  • License
    Apache License 2.0
  • Created almost 10 years ago
  • Updated 8 months ago

Reviews

There are no reviews yet. Be the first to send feedback to the community and the maintainers!

Repository Details

Erlang Style Reviewer

elvis Build Status

Elvis Presley dancing

Command-line interface for Elvis, the Erlang style reviewer.

Contact Us

If you find any bugs or have a problem while using this library, please open an issue in this repo (or a pull request :)).

Installation

  1. Clone the repo
  2. rebar3 compile

Usage

In any elvis-enabled product, elvis rock will trigger a rule check.

Script

elvis can be turned into a script by executing rebar3 escriptize. This will generate an elvis self-contained executable script, from which you can get help by typing elvis help. A list of available commands can be shown using the --commands option (i.e. elvis --commands).

To run elvis from the terminal use the rock command (i.e. elvis rock). There's no need to specify a configuration file path if you have an elvis.config file in the same location where you are executing the script, otherwise a configuration file can be specified through the use of the --config (or just -c) option.

elvis rock --config config/elvis.config

In 0.3.0 a new option was introduced in order to run elvis checks only on the source files that have changed since a particular branch of commit. Example usage would be elvis git-branch origin/HEAD.

Benefits

  • Enables consistency in style across all your code base.
  • Encourages the development team to sit down and talk about code conventions.
  • Allows continuous monitoring of code quality.
  • Helps developers avoid repeated mistakes that can be automatically detected.
  • Provides homogenisation among the different projects in a company, therefore facilitating project switching for developers and as well allowing easier code sharing between projects

Webhook

There's also a way to use elvis as a GitHub webhook for pull request (PR) events by calling the elvis_webhook:event/1 function. This will add a comment in each file and rule that is broken, analyzing only the files associated with the PR.

Running the webhook on your servers

Since GitHub's API needs a valid user and password to allow the creation of reviews on PRs, the parameters github_user and github_password need to be added to elvis's configuration and also the credentials used must be from an admin of the repo or someone with permissions for requesting changes on PRs.

The elvis_webhook:event/1 function takes a map containing the keys headers and body, whose values should be the map of headers and the body from the GitHub's event request.

Headers = #{<<"X-GitHub-Event">>, <<"pull_request">>},
Body = <<"{}">>, %% JSON data form GitHub's event.
Request = #{headers => Headers, body => Body},
elvis:webhook(Request).

Git hook

elvis can also be used as a git pre-commit hook using the git-hook command, just use something like the following as your pre-commit script:

#!/bin/sh
#
# Runs elvis rules to staged files where applicable.

elvis git-hook

As the comment states, elvis will search for files that match the filter of each rule group (see configuration) among the staged files, get their staged content and run the rules specified in the configuration. If any rule fails then elvis exits with a non-zero code, which signals git that the commit shouldn't be made.

Make sure your pre-commit hook script is executable (i.e. by running chmod +x pre-commit), otherwise git won't be able to run it.

Erlang Shell

If you only need to use elvis in the Erlang shell you might want to consider only including the elvis_core library as a dependency.

Configuration

To provide a default configuration for elvis you should either create an elvis.config file located in the root directory or set the following environment values in your configuration file:

[
 {
   elvis,
   [
    {config, [...]},
    {output_format, plain},

    %% Only necessary for the 'webhook' functionality
    {github_user, "user"},
    {github_password, "password"}
   ]
 }
].

The config and output_format are explained in elvis_core.

The GitHub configuration parameters github_user and github_password are required only when elvis is used as a webhook.

elvis.config

In your elvis.config file you can setup which rules should be applied, on what files and in which directories to do it.

The configuration is in Erlang format, it is not that hard to write but it is easier if you use the elvis.config file in this reposiotry as a template.

In the elvis.config file you create an elvis config where for a set of directories, you want to run a ruleset (or specific rules) on a set of files.

For example, configure to check all erlang files under the src directory using the ruleset erl_files:

[
 {
   elvis,
   [
    {config,
     [#{dirs => ["src"],
        filter => "*.erl",
        ruleset => erl_files
       }
     ]
    }
   ]
 }
].

You can use four different rulesets erl_files, makefiles, rebar_config or elvis_config.

Implemented Rules

A reference of all rules implemented in Elvis can be found in this elvis_core's RULES.md.

User Defined Rules

If you have implemented an Elvis rule that's in your local repo or in one of your dependencies, you can add this rule to your elvis.config file and tell Elvis where to find the .beam that contains the compiled rule using the --code-path (-p) option.

For example if the rule is in one of your deps, you could run Elvis in the following way:

elvis rock -p deps/elvis_rules/ebin -c elvis.config

Dependencies

  • Erlang/OTP 24+
  • git

References

Inspired on HoundCI

More Repositories

1

erlang_guidelines

Inaka's Erlang Coding Guidelines
Erlang
618
star
2

EventSource

A simple Swift client library for the Server Sent Events (SSE)
Swift
453
star
3

galgo

When you want your logs to be displayed on screen
Java
428
star
4

apns4erl

Apple Push Notification Server for Erlang
Erlang
370
star
5

TinyTask

A Tiny Task Library
Java
322
star
6

worker_pool

Erlang worker pool
Erlang
272
star
7

sumo_db

Erlang Persistency Framework
Erlang
173
star
8

shotgun

For the times you need more than just a gun.
Erlang
165
star
9

Dayron

A repository `similar` to Ecto.Repo that maps to an underlying http client, sending requests to an external rest api instead of a database
Elixir
159
star
10

cowboy_swagger

Swagger integration for Cowboy (built on trails)
Erlang
116
star
11

gold_fever

A Treasure Hunt for Erlangers
Erlang
86
star
12

Jayme

Abstraction layer that eases RESTful interconnections in Swift
Swift
81
star
13

guidelines

General Inaka Guidelines
74
star
14

cowboy-trails

A couple of improvements over Cowboy Routes
Erlang
70
star
15

jem.js

Just Erlang Maps for Javascript
JavaScript
69
star
16

sheldon

Very Simple Erlang Spell Checker
Erlang
62
star
17

niffy

Inline C code in Erlang modules to build NIFs
Erlang
60
star
18

sumo_rest

Generic cowboy handlers to work with Sumo
Erlang
59
star
19

serpents

Multi-Player Game on top of HDP protocol
Erlang
57
star
20

elvis_core

The core of an Erlang linter
Erlang
52
star
21

xref_runner

Erlang Xref Runner (inspired in rebar xref)
Erlang
50
star
22

erlang-github

Github API client
Erlang
46
star
23

lasse

SSE handler for Cowboy
Erlang
45
star
24

beam_olympics

Let's find the fastest beamer!
Erlang
39
star
25

fiar

Four in a Row - A game to learn Erlang
Erlang
36
star
26

zipper

Generic Zipper implementation in Erlang
Erlang
34
star
27

ios-xmpp-sample

Blog post sample project.
Swift
33
star
28

kotlillon

Android Kotlin Examples
Kotlin
33
star
29

katana-test

Meta Testing Utilities for common_test
Erlang
32
star
30

match_stream

A sample project to show in our scale blog post
JavaScript
30
star
31

phoenix_passwordless_login

Phoenix Passwordless Login
Elixir
29
star
32

KillerTask

Android AsyncTask wrapper library, written in Kotlin
Kotlin
26
star
33

canillita

Simple Paperboy-themed PubSub
Erlang
26
star
34

lewis

Rock your Android
Java
22
star
35

tirerl

Erlang interface to Elastic Search
Erlang
19
star
36

itweet

Twitter Stream API on ibrowse
Erlang
18
star
37

katana-code

Code Utilities for Erlang
Erlang
17
star
38

pusherman

queuing system for push notifications
Erlang
17
star
39

galgo-ios

When you want your logs to be displayed on screen
Objective-C
16
star
40

FadeButton

Fading effects for UIButtons made simple
Swift
16
star
41

lsl

NIM in Erlang
Erlang
15
star
42

credo_server

Credo Server
Elixir
15
star
43

Jolly

Jolly Chimp that keeps track of our Github Repos
Swift
12
star
44

rpsls

Rock Paper Scissors Lizzard Spock World Championship in Erlang
Erlang
12
star
45

ikbot

An elixir based customizable hipchat bot
Elixir
12
star
46

nconf

Nested Configuration Manager for Erlang Applications
Erlang
12
star
47

pushito

APNS over HTTP/2
Elixir
11
star
48

rest_guidelines

REST API Design Guidelines
11
star
49

fetjaba

From Erlang To Java and Back Again
Erlang
9
star
50

sumo_db_pgsql

PostgreSQL adapter for sumo_db.
Erlang
9
star
51

jinterface_stdlib

Erlang stdlib implementation on Java, based on JInterface
Java
9
star
52

IKCapture

Snapchat-Like Image Capture Library
Objective-C
8
star
53

PictureViewMaster

Interactive image projector.
Swift
8
star
54

toy_kv

A simple and reduced Key-Value Store written in Erlang
Erlang
7
star
55

ColorPicker

Color Picker for Swift
Swift
7
star
56

MediaPickerController

Neat API for presenting the classical action sheet for picking an image or video from the device or camera.
Swift
7
star
57

swift_guidelines

Inaka's Swift Coding Guidelines
7
star
58

spellingci

Spelling CI Server
Erlang
7
star
59

talks

Sources and pdfs of our talks and speeches
TeX
6
star
60

bookmarks

A collection of bookmarks for Inakos
6
star
61

IKJayma

RESTful API abstraction for Server Interconnection
Objective-C
6
star
62

hexer

Hex.pm integration in escript format.
Erlang
6
star
63

hexer.mk

erlang.mk plugin for hexer
Makefile
5
star
64

android_guidelines

Inaka's Android Development Guidelines
5
star
65

elvis.mk

3rd party erlang.mk plug-in for Elvis
Shell
5
star
66

plixir

Poker + Elixir + Phoenix
CSS
5
star
67

sumo_db_elasticsearch

ElasticSearch adapter for sumo_db
Erlang
4
star
68

tele_sign

Node.js library to send messages through http://www.telesign.com/
JavaScript
4
star
69

ios_guidelines

Inaka's iOS Coding Guidelines
Objective-C
3
star
70

sumo_db_riak

Riak adapter for sumo_db
Erlang
3
star
71

android-excercises

Quick test for Android candidates
3
star
72

sumo_db_mysql

MySQL adapter for sumo_db
Erlang
2
star
73

inaka.mk

erlang.mk extras that we generally use in all of our projects
Makefile
2
star
74

sumo_db_mongo

MongoDB adapter for sumo_db
Erlang
2
star
75

gold_fever-solver

A solver for the http://github.com/inaka/gold_fever game
Erlang
2
star
76

Otec

A swift app to showcase our best open-source libraries
Swift
2
star
77

inaka.github.io

Inaka's Open Source Projects
HTML
2
star
78

g2x

Graffle to XCode
Objective-C
2
star
79

beam_olympics-extended

Internal repo to keep secret beam_olympics tasks from the public view
Erlang
2
star
80

beam_olympics-solver

Solutions for beam_olympics
Elixir
2
star
81

ruby_guidelines

Our own guidelines when it comes to ruby development
1
star
82

pokedex

Dumb repo to prove what we can do with sumo{_db|rest_}
Erlang
1
star
83

homebrew-formulas

Homebrew formulas for some of our tools
Ruby
1
star
84

updike

Run, rabbit, run
1
star
85

ios-scripts

Helper scripts that you can use in your iOS apps
Shell
1
star
86

INSocketListener

SSE Socket Listener for Objective-C
Objective-C
1
star
87

emarkdown

Based on https://github.com/devinus/markdown - but for Erlang :)
C
1
star