emilybache/Tennis-Refactoring-Kata

Stars
649
Rank 69,373 (Top 2 %)
Language
TypeScript
License
MIT License
Created over 11 years ago
Updated 11 months ago

emilybache/Tennis-Refactoring-Kata

emilybache

There are no reviews yet. Be the first to send feedback to the community and the maintainers!

This is a Refactoring Kata based on the rules of Tennis

Tennis Refactoring Kata

Imagine you work for a consultancy company, and one of your colleagues has been doing some work for the Tennis Society. The contract is for 10 hours billable work, and your colleague has spent 8.5 hours working on it. Unfortunately he has now fallen ill. He says he has completed the work, and the tests all pass. Your boss has asked you to take over from him. She wants you to spend an hour or so on the code so she can bill the client for the full 10 hours. She instructs you to tidy up the code a little and perhaps make some notes so you can give your colleague some feedback on his chosen design. You should also prepare to talk to your boss about the value of this refactoring work, over and above the extra billable hours.

There are several versions of this refactoring kata, each with their own design smells and challenges. I suggest you start with the first one, with the class "TennisGame1". The test suite provided is fairly comprehensive, and fast to run. You should not need to change the tests, only run them often as you refactor.

There is a deliberate error in several of the implementations - the player names are hard-coded to "player1" and "player2". After you refactor, you may want to fix this problem and add suitable test cases to prove your fix works.

If you like this Kata, you may be interested in my books and website SammanCoaching.org

Kata Description

Here is a description of the problem this code is designed to solve: Tennis Kata.

Questions to discuss afterwards

How did it feel to work with such fast, comprehensive tests?
Did you make mistakes while refactoring that were caught by the tests?
If you used a tool to record your test runs, review it. Could you have taken smaller steps? Made fewer refactoring mistakes?
Did you ever make any refactoring mistakes and then back out your changes? How did it feel to throw away code?
What would you say to your colleague if they had written this code?
What would you say to your boss about the value of this refactoring work? Was there more reason to do it over and above the extra billable hour or so?

GildedRose-Refactoring-Kata

Starting code for the GildedRose Refactoring Kata in many programming languages.

Racing-Car-Katas

The starting code for several code katas on a racing car theme

Theatrical-Players-Refactoring-Kata

Example from first chapter of 'Refactoring' by Martin Fowler, with tests and translations

Parrot-Refactoring-Kata

Kata to learn about Polymorphism

KataTrainReservation

A Kata exercise. This one involves writing code to reserve seats on a train.

SupermarketReceipt-Refactoring-Kata

This is a refactoring kata for improving your coding skills

Yatzy-Refactoring-Kata

Starting code for a Refactoring Code Kata on the Yatzy rules

Phone-Numbers-Kata

Some sample data you could use to help test your solution to the Phone Numbers code kata, and a script to create it.

Product-Export-Refactoring-Kata

exercise for practicing refactoring

Lift-Kata

starting position for the Lift Kata with an Approval Testing approach

Clarify-Exception-Refactoring-Kata

For practicing refactoring, removing duplication, and making code more flexible

CustomerSync-Refactoring-Kata

Refactoring exercise where data layer and business layer are not clearly separated

DiamondKata

skeleton solution and test cases for comparing iterative and incremental approaches

Necklace-Refactoring-Kata

the goal is to practice refactoring to a Chain of Responsibility pattern

Online-Shopping-Kata

Refactoring Kata to practice teasing out incohesive, coupled code

Email-Sender-Refactoring-Kata

Code from Michael Feathers presentation about "Tell, Don't Ask" at Craft 2019

Hands-On-Approval-Testing-For-Developers-Materials

exercises for this training course offered via O'Reilly

ValidateAndAddProduct-Refactoring-Kata

a kata for practicing both testing with Combination Approvals and 'Split Phase' refactoring

vsftpd-server

docker image for vsftpd ftp server

StrangeCharacters-TestDesign-Kata

for writing tests that check correct objects are included in a list

OvertimeCalculation-Refactoring-Kata

a refactoring exercise with a complex conditional for dividing overtime hours into two rates

DeliveryController-Refactoring-Kata

refactoring kata where you need a mock or stub

Scrabble-Kata

starting code and instructions to help you with the Scrabble kata

KataMedicineClash

Sample solution and graph visualization code for the MedicineClash Code Kata

ApprovalTools

useful little scripts

Horse-Kata

An exercise for practicing Test-Driven Development

IceCreamForecasting-Refactoring-Kata

an exercise for getting awkward code under test

DungeonEscape-Refactoring-Kata

Write tests for a command line program that takes user input.

TimerExpiry-Refactoring-Kata

exercise to practice removing duplication

Single-Sign-On-Kata

a kata useful for understanding Test Doubles

CashMachine-Refactoring-Kata

sample code for explaining the Law of Demeter

LeapYearTestExamples

Documents a variety of ways to write unit tests for the Leap Year Kata

FancyCommand-Refactoring-Kata

For practicing refactoring techniques like 'peel' and approval testing xml

Encryptor-Refactoring-Kata

refactoring kata

RefactoringGolf

Practice using your refactoring tools with 'before' and 'after' code snippets

SafeCalculator-TestDesign-Kata

the code has a bug and needs some unit tests. You'll need a test double too.

VendingMachine-Approval-Kata

An exercise for learning about Approval testing and in particular designing a printer

personnummer

library for generating Swedish personal numbers for testing purposes

FizzBuzzKata-Samples

Some sample solutions to the FizzBuzz Kata, to provoke discussion.

BeeFriendly

app for learning about testing in a microservices architecture

pytest-approvaltests

Plugin to configure pytest for use with approval tests

Yatzy-Vendor-Assessment-Kata

Exercise in finding bugs in three competing implementations of the Yatzy rules

Approvals-Puzzles

Which of these programs are suitable to be tested with Approval Testing?

Theater-Kata

K8sAudit-Kata

an exercise for practicing TDD when you have dependencies on a REST API and a file system

starter

empty starting projects in various languages

StrangeCharacters-Refactoring-Kata

refactoring exercise to practice extract method and extract class

EventParserDesignKata

For better understanding that how you set up your tests changes the design of your production code.

TirePressure-Kata

code kata for learning more about test doubles and SOLID principles

LockController-Refactoring-Kata

for practicing testing a class with awkward dependencies

Refactor-Conditionals

some examples of ways to refactor conditional statements

Phonebook-Python-Example-Project

example project using Python and Pytest with standard layout of files

MarsRover-Kata

Sample solution to the Mars Rover Kata with different testing approaches

DiscountApplier-TestDesign-Kata

the code has bugs and needs some unit tests. You'll need a test double too.

ShoppingBasket-TDD-Kata

Starting code for doing the Shopping Basket kata with TDD https://sammancoaching.org/kata_descriptions/shopping_basket.html

Spiral-Refactoring-Kata

This code works but could do with some attention to make it more readable and maintainable.

Encode-TestDesign-Kata

the code works and the tests pass, can you make the code easier to maintain?

VoidFunctionNoArgs-Refactoring-Kata

exercise to practice getting a void function with no arguments under test and refactored

EnvironmentalControllerKata

sample code for discussing test design principles

gothpy-katas

A collection of code (mostly katas) done at the GothPy meetings

RPG-Combat-Approval-Kata

starting position for the RPG Combat Kata with an approval testing approach

Cloud-Migration-Refactoring-Kata

Exercise in good use of test doubles and the dangers of mandating 80% test coverage

FIRST-Test-Design-Kata

to practice writing test cases that follow the FIRST principles

FizzBuzz-Refactoring-Kata

For practicing "make the change easy, then make the easy change"

TicTacToe-Kata

Starting code for the TicTacToe Kata including a printer for the board

UI-Katas

Kata exercises that have user interfaces.

Roadload-Refactoring-Kata

A calculation with some duplication and no tests

Yatzy-Approval-Kata

Excercise to help you learn how to use approval testing and TextTest in particular

Device-Driver-Kata

a Kata for practicing the use of Mocks

RecentlyUsedList-Test-Design-Kata

for practicing test design, fixtures in particular

GameOfLife-Refactoring-Kata

Code that works but which could do with some attention to make it more readable and maintainable.

patients

Sample application for testing

Recently-Used-List-Docs

practice writing user documentation based on unit tests

ApprovalTests.Python

python port of the ApprovalTests library http://approvaltests.sourceforge.net/

CalcStats-TestDesign-Kata

for practicing test design using https://sammancoaching.org/kata_descriptions/calc_stats.html

sbt-texttest

SBT plugin that can run texttests in your sbt projects.

buildstats

keep track of how long the build is taking

ChainOfResponsibility-Pets

A lighthearted codebase to remind you what a Chain Of Responsibility design pattern looks like

WikiSearchKata

a kata for practicing a refactoring: template method -> strategy pattern

Yatzy-Prompts

for introducing typist and navigator roles

GildedRose-Approval-Kata

Same problem code as for GildedRose-Refactoring-Kata, but set up for TextTest Approval tests

MarsRover-Screencast

the repo I used when I recorded myself solving this kata in Java

MetricTables-Kata

starting position for a from-scratch TDD exercise

HtmlConverter-Kata

Code kata for learning about test doubles and SOLID principles

TestDesign-Samples

some examples to get you thinking about test design.

TrigMath-Kata

some code for trig math calculations that you should add tests for, as an exercise

PipelineSimulation

Screencast-Katas

The code I end up with after doing a screencast

Instavoiced-Architecture-Kata

Materials to supplement this kata

ShoppingBasket-Test-Design-Kata

to practice making full use of your test framework to get the best possible feedback when you have a bug

MarsRover-Sample-Tests

sample tests for mars rover kata, for review

texttest-maven-plugin

Plugin to enable you to run tests created with TextTest as part of a maven build.

SupermarketReceipt-Java

just the java version of this refactoring kata

Supermarket-Kata-Sample-Tests

Sample test cases for Supermarket Kata, for review and discussion

ClosestToZero-Parameterized

practice writing parameterized tests and interpreting failures

Auction-TestDesign-Kata

for learning about test design, specifically with Mocks

TurnTicket-Kata

Code kata for learning more about Test Doubles and SOLID principles

WordWrap-TestDesign-Kata

several implementations which you can test with the same test cases

HandbagEvent-Refactoring-Kata

Exercise to practice sorting out a bumpy road smell