Mobile Wallet

Mobile Wallet is an Android-based framework for mobile wallets based on top of Fineract. The app follows clean architecture and contains a core library module that can be used as a dependency in any other wallet based project. It is developed at MIFOS together with a global community.

Development	Chat

How to Contribute

Thank you for your interest in contributing to the Mobile Wallet project by Mifos! We welcome all contributions and encourage you to follow these guidelines to ensure a smooth and efficient collaboration process.

The issues should be raised via the GitHub issue tracker. For Issue tracker guidelines please click here. All fixes should be proposed via pull requests. For pull request guidelines please click here. For commit style guidelines please click here.

Branch Policy

We have the following branches :

dev All the contributions should be pushed to this branch. If you're making a contribution, you are supposed to make a pull request to dev. Please make sure it passes a build check on Travis.

It is advisable to clone only the development branch using the following command:

git clone -b <branch> <remote_repo>

With Git 1.7.10 and later, add --single-branch to prevent fetching of all branches. Example, with development branch:

git clone -b dev --single-branch https://github.com/username/mobile-wallet.git
master The master branch contains all the stable and bug-free working code. The development branch once complete will be merged with this branch.

Demo credentials

Fineract Instance: demo.mifos.io username: demoUser123 password: password

Development Setup

Before you begin, you should have already downloaded the Android Studio SDK and set it up correctly. You can find a guide on how to do this here: Setting up Android Studio.

Fork the Git Repository

Forking the repository is the first step to start contributing. Click on the "Fork" button in the top right corner of the Mobile Wallet (Mifos Pay) repository to create your own fork.

Forking creates a copy of the project under your GitHub account. This enables you to work on changes without affecting the original repository directly.
Clone the Forked Repository

Once you have forked the repository, you need to clone it to your local development environment. Open a terminal or Git Bash and use the following command:
```
git clone https://github.com/yourUsername/mobile-wallet.git
```
Replace yourUsername with your actual GitHub username. Cloning creates a local copy of the repository on your machine, allowing you to make changes and contributions.
Working Locally on Your Cloned Repository

After cloning, navigate to the project directory using the terminal or Git Bash.

Before making any changes, create a new branch dedicated to the feature or bug fix you'll be working on:
```
git checkout -b "new-branch-name"
```
Ensure that new-branch-name reflects the purpose of your changes (e.g., add-payment-feature or fix-bug-123).

Make the necessary changes to the files to address the issue you're working on. Once you're done, you will be ready to proceed with verifying and committing your changes.
Perform a Gradle Check

All your pull requests must pass the CI build only then, it will be allowed to merge. Sometimes, when the build doesn't pass you can use these commands in your local terminal and check for the errors,

For Mac OS, you can use the following commands:

./gradlew check quality checks on your project’s code using Checkstyle and generates reports from these checks.
./gradlew spotlessApply an check and apply formatting to any plain-text file.
./gradlew build provides a command line to execute build script.

For Windows, you can use the following commands:

gradlew check quality checks on your project’s code using Checkstyle and generates reports from these checks.
gradlew spotlessApply an check and apply formatting to any plain-text file.
gradlew build provides a command line to execute build script.

Committing Your Changes

When you've finished making your changes and have tested them locally, it's time to commit your work:

Stage Changes

Use the following command to stage all changes:
```
git add .
```
This adds all modified and new files to the staging area, preparing them for the commit.
Commit Changes

Commit your changes with a meaningful commit message that describes the purpose of your changes:
```
git commit -m "Your commit message goes here"
```
A good commit message is concise and provides enough context about the changes made. Mifos follows its own commit style guidelines that you must follow. Learn more about it here.
Push Changes

Push your changes to your forked repository on GitHub:
```
git push origin new-branch-name
```
Replace new-branch-name with the name of the branch you created earlier.

Making a Pull Request

Once your changes are pushed to your forked repository, you can initiate a pull request to merge your changes into the main project:

Navigate to the Mobile Wallet (Mifos Pay) repository on GitHub.
Click on the "Pull Requests" tab and then click "New Pull Request."

Ensure the base repository is set to "openMF/mobile-wallet" and the base branch is the main development branch dev.
Set the compare repository to your forked repository and the compare branch to the branch you just created with your changes (e.g., in my case, the head repository was set to “rchtgpt/mobile-wallet” and the comparison branch was kotlin-migration-common.
Fill out the pull request template, providing a clear description of your changes, why they are necessary, and any relevant information for the reviewers.
Click "Create Pull Request" to submit your changes for review.

Squashing Your Commits

It is common for pull requests to undergo multiple rounds of review before being merged. To keep the Git history clean and organized, you should always squash your commits before finalizing the merge. Here's how you can do it:

Squash your commits:
```
git rebase -i HEAD~x
```
Replace x with the number of commits you want to squash. An interactive rebase will open, allowing you to choose how to combine the commits. Change pick to squash (or simply s) for all but the topmost commit. Save and exit the editor.
Amend the commit message if needed.
```
git commit --amend
```
Force push the changes to your forked repository:
```
git push --force origin your-branch-name
```
Please note that force pushing rewrites the Git history, so use it with caution.

Solving Merge Conflicts

In some cases, your pull request might encounter merge conflicts when the changes cannot be automatically merged with the main branch. To resolve merge conflicts:

Update your local branch with the latest changes from the main repository:

git fetch upstream
git checkout your-branch-name
git rebase upstream/master

Git will pause when encountering conflicts. Open the affected files, resolve the conflicts manually, and save the changes.
After resolving all conflicts, stage the changes and continue with the rebase:
```
git add .
git rebase --continue
```
Finally, force push the changes to your forked repository:
```
git push --force origin your-branch-name
```

Your pull request will be updated with the resolved conflicts, and the reviewers can proceed with the review process. Again, don’t forget to squash your commits.

Conclusion

By following these contribution guidelines, you're all set to start contributing to the Mobile Wallet (Mifos Pay) project. We appreciate your efforts and look forward to your valuable contributions. Happy coding!

Instructions to get the latest APK

To get the latest apk fom the Github actions artifacts, follow these steps:

Navigate to the Actions tab of this repository.
Click the latest workflow from the workflows list.
Scroll down to the Artifacts section and click the mobile-wallet hyperlink.
After successful download, extract the zip file to your preferred location.