• Stars
    star
    3,518
  • Rank 12,636 (Top 0.3 %)
  • Language
  • License
    Creative Commons ...
  • Created about 3 years ago
  • Updated 10 months ago

Reviews

There are no reviews yet. Be the first to send feedback to the community and the maintainers!

Repository Details

๐Ÿง˜ Things I think about when I write React code ๐Ÿง˜

react-philosophies

Epic React Exercises buy me coffee PRs welcome! Forever a work in progress! Stand With Ukraine

If react-philosophies helped you in some way, consider buying me a few cups of coffee โ˜•โ˜•โ˜•. This motivates me to create more React "stuff"! ๐Ÿ™‚

You have to think about what is the right way, even when you have the right idea of what the building blocks should be, there is huge flexibility in how you decide to put the whole system together. It is a craft... and it has a lot to do with valuing simplicity over complexity. Many people do have a tendency to make things more complicated than they need to be... The more stuff you throw into a system, the more complicated it gets and the more likely it is not going to work properly. - Barbara Liskov

Translations to other languages

Table of Contents

  1. Introduction
  2. The Bare Minimum
  3. Design for happiness
  4. Performance tips
  5. Testing principles
  6. Insights shared by others
The way this document is organized
It was actually difficult for me to separate my thoughts into the `design`, `performance`, and `testing`. I noticed that lot of designs intended for maintainability also make your application faster and easier to test. Apologies if the discussion appears to be cluttered at times.
Thanks for all the PRs ๐Ÿšœ, coffee โ˜•, recommended readings ๐Ÿ“š, and sharing of ideas ๐Ÿ’ก (View contributors)

โค๏ธ Comments, suggestions, violent reactions? I'd love to hear them!

If there's something that you think should be part of my reading list or/and if you have great ideas that you think I should include here, don't hesitate to submit a PR or an issue. Particularly, I've included the section Insights shared by others, should you wish to add your own ideas ๐Ÿ™‚. Broken links, grammar, formatting, and typographical error corrections are also welcome. Any contribution to improve react-philosophies whether big or small is always appreciated.


โค๏ธ Special thanks to those who took the time contribute!

Note, the following is not an exhaustive list, if you've contributed to this project and you don't see your name included, feel free to submit an PR that adds your name here. Thanks!

๐Ÿ’ก Comments and suggestions

โ˜• Coffee!

๐Ÿšœ Pull Requests

๐Ÿ“š Suggested Readings

๐Ÿง˜ 0. Introduction

react-philosophies is:

  • things I think about when I write React code.
  • at the back of my mind whenever I review someone else's code or my own
  • just guidelines and NOT rigid rules
  • a living document and will evolve over time as my experience grows
  • mostly techniques which are variations of basic refactoring methods, SOLID principles, and extreme programming ideas... just applied to React specifically ๐Ÿ™‚

react-philosophies is inspired by various places I've stumbled upon at different points of my coding journey.

Here are a few of them:

As a seasoned developer I have certain quirks, opinions, and common patterns that I fall back on. Having to explain to another person why I am approaching a problem in a particular way is really good for helping me break bad habits and challenge my assumptions, or for providing validation for good problem solving skills. - Coraline Ada Ehmke

๐Ÿง˜ 1. The Bare Minimum

1.1 Recognize when the computer is smarter than you

  1. Statically analyze your code with ESLint. Enable the rule-of-hooks and exhaustive-deps rule to catch React-specific errors.
  2. Enable "strict" mode. It's 2022.
  3. Be honest about your dependencies. Fix exhaustive-deps warnings / errors on your useMemo's, useCallback's and useEffect's. You can try "The latest ref pattern" to keep your callbacks always up-to-date without unnecessary rerenders.
  4. Always add keys whenever you use map to display components.
  5. Only call hooks at the top level. Donโ€™t call Hooks inside loops, conditions, or nested functions.
  6. Understand the warning "Can't perform state update on unmounted component". facebook/react/pull/22114
  7. Prevent the "white screen of death" by adding several error boundaries at different levels of your application. You can also use them to send alerts to an error monitoring service such as Sentry if you want to. (Accounting for Failures In React)
  8. There is a reason why errors and warnings are displayed in the console.
  9. Remember tree-shaking!
  10. Prettier (or an alternative) formats your code for you, giving you consistent formatting every time. You no longer need to think about it!
  11. Typescript and frameworks such as NextJS make your life so much easier.
  12. I highly recommend Code Climate (or similar) for open-source repositories or if you can afford it. I find that automatically-detected code smells truly motivates me to reduce the technical debts of the application I'm working on!

1.2 Code is just a necessary evil

"The best code is no code at all. Every new line of code you willingly bring into the world is code that has to be debugged, code that has to be read and understood, code that has to be supported." - Jeff Atwood

"One of my most productive days was throwing away 1000 lines of code." - Eric S. Raymond

See also: Write Less Code - Rich Harris, Code is evil - Artem Sapegin

1.2.1 Think first before adding another dependency

Needless to say, the more you add dependencies, the more code you ship to the browser. Ask yourself, are you actually using the features which make a particular library great?

๐Ÿ™ˆ Do you really need it? View examples of dependencies / code you might not need
  1. Do you really need Redux? It's possible. But keep in mind that React is already a state management library.

  2. Do you really need Apollo client ? Apollo client has many awesome features, like manual normalization. However, it will significantly increase your bundle size. If your application only makes use of features that are not unique to Apollo client , consider using a smaller library such as react-query or SWR (or none at all).

  3. Axios? Axios is a great library with features that are not easily replicable with native fetch. But if the only reason for using Axios is that it has a better looking API, then consider just using a wrapper on top of fetch (such as redaxios or your own). Determine whether or not your application is actually using Axios's best features.

  4. Decimal.js? Maybe Big.js or other smaller libraries are sufficient.

  5. Lodash/underscoreJS? you-dont-need/You-Dont-Need-Lodash-Underscore

  6. MomentJS? you-dont-need/You-Dont-Need-Momentjs

  7. You might not need Context for theming (light/dark mode), consider using css variables instead.

  8. You might not even need Javascript. CSS is powerful. you-dont-need/You-Dont-Need-JavaScript


1.2.2 Don't be clever. YAGNI!

"What could happen with my software in the future? Oh yeah, maybe this and that. Letโ€™s implement all these things since we are working on this part anyway. That way itโ€™s future-proof."

You Aren't Gonna Need It! Always implement things when you actually need them, never when you just foresee that you may need them. The less code the better! (Martin Fowler: YAGNI, C2 Wiki: You Arent Gonna Need It!)

Related section: 2.4 Duplication is far cheaper than the wrong abstraction

1.3 Leave it better than you found it

1.3.1 Detect code smells and do something about them if you need to.

If you recognize that something is wrong, fix it right then and there. But if it's not that easy to fix or you don't have time to fix it at that moment, at least add a comment (FIXME or TODO) with a concise explanation of the identified problem. Make sure everybody knows it is broken. It shows others that you care and that they should also do the same when they encounter those kinds of things.

๐Ÿ™ˆ View examples of easy-to-catch code smells
  • โŒ Methods or functions defined with a large number of arguments
  • โŒ Boolean logic that may be hard to understand
  • โŒ Excessive lines of code within a single file
  • โŒ Duplicate code which is syntactically identical (but may be formatted differently)
  • โŒ Functions or methods that may be hard to understand
  • โŒ Classes / Components defined with a large number of functions or methods
  • โŒ Excessive lines of code within a single function or method
  • โŒ Functions or methods with a large number of return statements
  • โŒ Duplicate code which is not identical but shares the same structure (e.g. variable names may differ)

Keep in mind that code smells don't necessarily mean that code should be changed. A code smell just informs you that you might be able to think of a better way to implement the same functionality.

1.3.2 Merciless Refactoring. Simple is better than complex.

Is the CL more complex than it should be? Check this at every level of the CLโ€”are individual lines too complex? Are functions too complex? Are classes too complex? โ€œToo complexโ€ usually means โ€œcanโ€™t be understood quickly by code readers.โ€ It can also mean โ€œdevelopers are likely to introduce bugs when they try to call or modify this code.โ€- Google Engineering Practices: What to look for in a code review

๐Ÿ’โ€โ™€๏ธ TIP: Simplify complex conditionals and exit early if you can.

๐Ÿ™ˆ Example of early returns
# โŒ Not-so-good

if (loading) {
  return <LoadingScreen />
} else if (error) {
  return <ErrorScreen />
} else if (data) {
  return <DataScreen />
} else {
  throw new Error('This should be impossible')
}

# โœ… BETTER


if (loading) {
  return <LoadingScreen />
} 

if (error) {
  return <ErrorScreen />
}

if (data) {
  return <DataScreen />
}

throw new Error('This should be impossible')

๐Ÿ’โ€โ™€๏ธ TIP: Prefer chained higher-order functions over loops

If there is no discernable performance difference and if possible, replace traditional loops with chained higher-order functions (map, filter, find, findIndex, some, etc) Stackoverflow: What is the advantage of using a function over loops?

1.4 You can do better

๐Ÿ’โ€โ™€๏ธ TIP: Remember that you may not need to put your state as a dependency because you can pass a callback function instead.

You don't need to put setState (from useState) and dispatch (from useReducer) in your dependency array for hooks like useEffect and useCallback. ESLint will NOT complain because React guarantees their stability.

๐Ÿ™ˆ View example
โŒ Not-so-good
const decrement = useCallback(() => setCount(count - 1), [setCount, count])
const decrement = useCallback(() => setCount(count - 1), [count])

โœ… BETTER
const decrement = useCallback(() => setCount(count => (count - 1)), [])

๐Ÿ’โ€โ™€๏ธ TIP: If your useMemo or useCallback doesn't have a dependency, you might be using it wrong.

๐Ÿ™ˆ View example
โŒ Not-so-good
const MyComponent = () => {
   const functionToCall = useCallback(x: string => `Hello ${x}!`,[])
   const iAmAConstant = useMemo(() => { return {x: 5, y: 2} }, [])
   /* I will use functionToCall and iAmAConstant */
}
       
โœ… BETTER 
const I_AM_A_CONSTANT =  { x: 5, y: 2 }
const functionToCall = (x: string) => `Hello ${x}!`
const MyComponent = () => {
   /* I will use functionToCall and I_AM_A_CONSTANT */
}

๐Ÿ’โ€โ™€๏ธ TIP: Wrapping your custom context with a hook creates a better-looking API

Not only does it look better, but you also only have to import one thing instead of two.

๐Ÿ™ˆ View example

โŒ Not-so-good

// you need to import two things every time 
import { useContext } from "react"
import { SomethingContext } from "some-context-package"

function App() {
  const something = useContext(SomethingContext) // looks okay, but could look better
  // blah
}

โœ… Better

  
// on one file you declare this hook
function useSomething() {
  const context = useContext(SomethingContext)
  if (context === undefined) {
    throw new Error('useSomething must be used within a SomethingProvider')
  }
  return context
}
  
// you only need to import one thing each time
import { useSomething } from "some-context-package"

function App() {
  const something = useSomething() // looks better
  // blah
}  

๐Ÿ’โ€โ™€๏ธ TIP: Think about how your component will be used before coding it

Writing APIs is hard. README Driven Development is one useful technique to help design better APIs. I'm not saying we should RDD religiously, just saying that the idea behind it is great. I find that when I first write the API (how the component will be used) before implementing it, this usually creates a better designed component than when I don't.

๐Ÿง˜ 2. Design for happiness

"Any fool can write code that a computer can understand. Good programmers write code that humans can understand." - Martin Fowler

"The ratio of time spent reading versus writing is well over 10 to 1. We are constantly reading old code as part of the effort to write new code. So if you want to go fast, if you want to get done quickly, if you want your code to be easy to write, make it easy to read." โ€• Robert C. Martin (Not saying I agree with his political views)

TL;DR

  1. ๐Ÿ’– Avoid state management complexity by removing redundant states
  2. ๐Ÿ’– Pass the banana, not the gorilla holding the banana and the entire jungle (prefer passing primitives as props)
  3. ๐Ÿ’– Keep your components small and simple - the single responsibility principle!
  4. ๐Ÿ’– Duplication is far cheaper than the wrong abstraction (avoid premature / inappropriate generalization)
  5. Avoid prop drilling by using composition (Michael Jackson). Context is not the solution for every state sharing problem
  6. Split giant useEffects to smaller independent ones (KCD: Myths about useEffect)
  7. Extract logic to hooks and helper functions
  8. Prefer having mostly primitives as dependencies to useCallback, useMemo, and useEffect
  9. Do not put too many dependencies in useCallback, useMemo, and useEffect
  10. For simplicity, instead of having many useStates, consider using useReducer if some values of your state rely on other values of your state and previous state
  11. Context does not have to be global to your whole app. Put Context as low as possible in your component tree. Do this the same way you put variables, comments, states (and code in general) as close as possible to where they're relevant / being used.

๐Ÿ’– 2.1 Avoid state management complexity by removing redundant states

When you have redundant states, some states may fall out of sync; you may forget to update them given a complex sequence of interactions. Aside from avoiding synchronization bugs, you'd notice that it's also easier to reason about and require less code. See also: KCD: Don't Sync State. Derive It!, Tic-Tac-Toe

๐Ÿ™ˆ Example 1
๐Ÿ“๐Ÿ–Š๏ธ View the business requirement / problem statement

You are tasked to display properties of a right triangle

  • the lengths of each of the three sides
  • the perimeter
  • the area

The triangle is an object with two numbers {a: number, b: number} that should be fetched from an API. The two numbers represent the two shorter sides of a right triangle.


โŒ View not-so-good Solution
const TriangleInfo = () => {
  const [triangleInfo, setTriangleInfo] = useState<{a: number, b: number} | null>(null)
  const [hypotenuse, setHypotenuse] = useState<number | null>(null)
  const [perimeter, setPerimeter] = useState<number | null>(null)
  const [areas, setArea] = useState<number | null>(null)

  useEffect(() => {
    fetchTriangle().then(t => setTriangleInfo(t))
  }, [])

  useEffect(() => {
    if(!triangleInfo) {
      return
    }
    
    const { a, b } = triangleInfo
    const h = computeHypotenuse(a, b)
    setHypotenuse(h)
    const newArea = computeArea(a, b)
    setArea(newArea)
    const p = computePerimeter(a, b, h)
    setPerimeter(p)

  }, [triangleInfo])

  if (!triangleInfo) {
    return null
  }

  /*** show info here ****/
}
โœ… View "better" solution
const TriangleInfo = () => {
  const [triangleInfo, setTriangleInfo] = useState<{
    a: number;
    b: number;
  } | null>(null)

  useEffect(() => {
    fetchTriangle().then((r) => setTriangleInfo(r))
  }, []);

  if (!triangleInfo) {
    return
  }

  const { a, b } = triangeInfo
  const area = computeArea(a, b)
  const hypotenuse = computeHypotenuse(a, b)
  const perimeter = computePerimeter(a, b, hypotenuse)
 
  /*** show info here ****/
};
๐Ÿ™ˆ Example 2
๐Ÿ“๐Ÿ–Š๏ธ View the business requirement / problem statement

Suppose you are assigned to design a component which:

  1. Fetches a list of unique points from an API
  2. Includes a button to either sort by x or y (ascending order)
  3. Includes a button to change the maxDistance (increase by 10 each time, initial value should be 100)
  4. Only displays the points that are NOT farther than the current maxDistance from the origin (0, 0)
  5. Assume that the list only has 100 items (meaning you don't need to worry about optimization). If you're working with really large numbers of items, you can memoize some computations with useMemo.

โŒ View a not-so-good Solution
type SortBy = 'x' | 'y'
const toggle = (current: SortBy): SortBy => current === 'x' ? : 'y' : 'x'

const Points = () => {
  const [points, setPoints] = useState<{x: number, y: number}[]>([])
  const [filteredPoints, setFilteredPoints] = useState<{x: number, y: number}[]>([])
  const [sortedPoints, setSortedPoints] = useState<{x: number, y: number}[]>([])
  const [maxDistance, setMaxDistance] = useState<number>(100)
  const [sortBy, setSortBy] = useState<SortBy>('x')
  
  useEffect(() => {
    fetchPoints().then(r => setPoints(r))
  }, [])
  
  useEffect(() => {
    const sorted = sortPoints(points, sortBy)
    setSortedPoints(sorted)
  }, [sortBy, points])

  useEffect(() => {
    const filtered = sortedPoints.filter(p => getDistance(p.x, p.y) < maxDistance)
    setFilteredPoints(filtered)
  }, [sortedPoints, maxDistance])

  const otherSortBy = toggle(sortBy)
  const pointToDisplay = filteredPoints.map(
    p => <li key={`${p.x}|{p.y}`}>({p.x}, {p.y})</li>
  )

  return (
    <>
      <button onClick={() => setSortBy(otherSortBy)}>
        Sort by: {otherSortBy}
      <button>
      <button onClick={() => setMaxDistance(maxDistance + 10)}>
        Increase max distance
      <button>
      Showing only points that are less than {maxDistance} units away from origin (0, 0)
      Currently sorted by: '{sortBy}' (ascending)
      <ol>{pointToDisplay}</ol>
    </>
  )
}
โœ… View a "better" Solution
// NOTE: You can also use useReducer instead
type SortBy = 'x' | 'y'
const toggle = (current: SortBy): SortBy => current === 'x' ? : 'y' : 'x'

const Points = () => {
  const [points, setPoints] = useState<{x: number, y: number}[]>([])
  const [maxDistance, setMaxDistance] = useState<number>(100)
  const [sortBy, setSortBy] = useState<SortBy>('x')

  useEffect(() => {
    fetchPoints().then(r => setPoints(r))
  }, [])
  

  const otherSortBy = toggle(sortBy)
  const filtedPoints = points.filter(p => getDistance(p.x, p.y) < maxDistance)
  const pointToDisplay = sortPoints(filteredPoints, sortBy).map(
    p => <li key={`${p.x}|{p.y}`}>({p.x}, {p.y})</li>
  )

  return (
    <>
      <button onClick={() => setSortBy(otherSortBy)}>
        Sort by: {otherSortBy} <button>
      <button onClick={() => setMaxDistance(maxDistance + 10)}>
        Increase max distance
      <button>
      Showing only points that are less than {maxDistance} units away from origin (0, 0)
      Currently sorted by: '{sortBy}' (ascending)
      <ol>{pointToDisplay}</ol>
    </>
  )
}

๐Ÿ’– 2.2 Pass the banana, not the gorilla holding the banana and the entire jungle

You wanted a banana but what you got was a gorilla holding the banana and the entire jungle. - Joe Armstrong

To avoid falling into this trap, it's a good idea to pass mostly primitives (boolean, string, number, etc) types as props. (Passing primitives is also a good idea if you want to use React.memo for optimization)

A component should just know enough to do its job and nothing more. As much as possible, components should be able to collaborate with others without knowing what they are and what they do.

When we do this, the components will be more loosely coupled, the degree of dependency between two components will be lower. Loose coupling makes it easier to change, replace, or remove components without affecting other components. stackoverflow:2832017

๐Ÿ™ˆ Example
๐Ÿ“๐Ÿ–Š๏ธ View the business requirement / problem statement

Create a MemberCard component that displays two components: Summary and SeeMore. The MemberCard takes in the prop id . The MemberCard consumes the hook useMember which takes in an id and returns the corresponding Member information.

type Member = {
  id: string
  firstName: string
  lastName: string
  title: string
  imgUrl: string
  webUrl: string
  age: number
  bio: string
  /****** 100 more fields ******/
}

The SeeMore component should display the age and bio of the member. Include a button to toggle between showing and hiding the age and bio of the member.

The Summary component displays the picture of the member. It also displays his title, firstName and lastName (e.g. Mr. Vincenzo Cassano). Clicking the member's name should take you to the member's personal site. The Summary component may also have other functionalities. (Example, whenever this component is clicked... the font, size of the image, and background color are randomly changed... for brevity let's call this "the random styling feature")


โŒ View a not-so-good solution
const Summary = ({ member } : { member: Member }) => {
  /*** include "the random styling feature" ***/
  return (
    <>
      <img src={member.imgUrl} />
      <a href={member.webUrl} >
        {member.title}. {member.firstName} {member.lastName}
      </a>
    </>
  )
}

const SeeMore = ({ member }: { member: Member }) => {
  const [seeMore, setSeeMore] = useState<boolean>(false)
  return (
    <>
      <button onClick={() => setSeeMore(!seeMore)}>
        See {seeMore ? "less" : "more"}
      </button>
      {seeMore && <>AGE: {member.age} | BIO: {member.bio}</>}
    </>
  )
}

const MemberCard = ({ id }: { id: string })) => {
  const member = useMember(id)
  return <><Summary member={member} /><SeeMore member={member} /></>
}
โœ… View a "better" solution
const Summary = ({ imgUrl, webUrl, header }: { imgUrl: string, webUrl: string, header: string }) => {
  /*** include "the random styling feature" ***/
  return (
    <>
      <img src={imgUrl} />
      <a href={webUrl}>{header}</a>
    </>
  )
}

const SeeMore = ({ componentToShow }: { componentToShow: ReactNode }) => {
  const [seeMore, setSeeMore] = useState<boolean>(false)
  return (
    <>
      <button onClick={() => setSeeMore(!seeMore)}>
        See {seeMore ? "less" : "more"}
      </button>
      {seeMore && <>{componentToShow}</>}
    </>
  )
}


const MemberCard = ({ id }: { id: string }) => {
  const { title, firstName, lastName, webUrl, imgUrl, age, bio } = useMember(id)
  const header = `${title}. ${firstName} ${lastName}`
  return (
    <>
      <Summary {...{ imgUrl, webUrl, header }} />
      <SeeMore componentToShow={<>AGE: {age} | BIO: {bio}</>} />
    </>
  )
}

Notice that in the โœ… "better" solution", SeeMore and Summary are components that can be used not just by Member. It can be used perhaps by other objects such as CurrentUser, Pet, Post... anything that needs those specific functionality.

๐Ÿ’– 2.3 Keep your components small and simple

What is the single responsibility principle?

A component should have one and only one job. It should do the smallest possible useful thing. It only has responsibilities that fulfill its purpose.

A component with various responsibilities is difficult to reuse. If you want to reuse some but not all of its behavior, it's almost always impossible to just get what you need. It is also likely to be entangled with other code. Components that do one thing which isolate that thing from the rest of your application allows change without consequence and reuse without duplication.

How to know if your component has a single responsibility?

Try to describe that component in one sentence. If it is only responsible for one thing then it should be simple to describe. If it uses the word โ€˜andโ€™ or โ€˜orโ€™ then it is likely that your component fails this test.

Inspect the component's state, the props and hooks it consumes, as well as variables and methods declared inside the component (there shouldn't be too many). Ask yourself: Do these things actually work together to fulfill the component's purpose? If some of them don't, consider moving those somewhere else or breaking down your big component into smaller ones.

(The paragraphs above are based on my 2015 article: Three things I learned from Sandi Metzโ€™s book as a non-Ruby programmer)

๐Ÿ™ˆ Example
๐Ÿ“๐Ÿ–Š๏ธ View the business requirement / problem statement

The requirement is to display special kinds of buttons you can click to shop for items of a specific category. For example, the user can select bags, chairs, and food.

  • Each button opens a modal you can use to select and "save" items
  • If the user has "saved" selected items in a specific category, that category said to be "booked"
  • If it is booked, the button will have a checkmark
  • You should be able to edit your booking (add or delete items) even if that category is booked
  • If the user is hovering the button it should also display WavingHand component
  • A button should also be disabled when no items for that specific category is available
  • When a user hovers a disabled button, a tooltip should show "Not Available"
  • If the category has no items available, the button's background should be grey
  • If the category is booked, the button's background should be green
  • If the category has available items and is not booked, the button's background should be red
  • For each category, its corresponding button has a unique label and icon

โŒ View a not-so-good solution
type ShopCategoryTileProps = {
  isBooked: boolean
  icon: ReactNode
  label: string
  componentInsideModal?: ReactNode
  items?: {name: string, quantity: number}[]
}

const ShopCategoryTile = ({
  icon,
  label,
  items
  componentInsideModal,
}: ShopCategoryTileProps ) => {
  const [openDialog, setOpenDialog] = useState(false)
  const [hover, setHover] = useState(false)
  const disabled = !items || items.length  === 0
  return (
    <>
      <Tooltip title="Not Available" show={disabled}>
        <StyledButton
          className={disabled ? "grey" : isBooked ? "green" : "red" }
          disabled={disabled}
          onClick={() => disabled ? null : setOpenDialog(true) }
          onMouseEnter={() => disabled ? null : setHover(true)}
          onMouseLeave={() => disabled ? null : setHover(false)}
        >
          {icon}
          <StyledLabel>{label}<StyledLabel/>
          {!disabled && isBooked && <FaCheckCircle/>}
          {!disabled && hover && <WavingHand />}
        </StyledButton>
      </Tooltip>
      {componentInsideModal &&
        <Dialog open={openDialog} onClose={() => setOpenDialog(false)}>
          {componentInsideModal}
        </Dialog>
      }
    </>
  )
}
โœ… View a "better" solution
// split into two smaller components!

const DisabledShopCategoryTile = ({ icon, label }: { icon: ReactNode, label: string }) => {
  return (
    <Tooltip title="Not available">
      <StyledButton disabled={true} className="grey">
        {icon}
        <StyledLabel>{label}<StyledLabel/>
      </Button>
    </Tooltip>
  )
}

type ShopCategoryTileProps = {
  icon: ReactNode
  label: string
  isBooked: boolean
  componentInsideModal: ReactNode
}

const ShopCategoryTile = ({
  icon,
  label,
  isBooked,
  componentInsideModal,
}: ShopCategoryTileProps ) => {
  const [openDialog, setOpenDialog] = useState(false)
  const [hover, setHover] = useState(false)

  return (
    <>
      <StyledButton
        disabled={false}
        className={isBooked ? "green" : "red"}
        onClick={() => setOpenDialog(true) }
        onMouseEnter={() => setHover(true)}
        onMouseLeave={() => setHover(false)}
      >
        {icon}
        <StyledLabel>{label}<StyledLabel/>
        {isBooked && <FaCheckCircle/>}
        {hover && <WavingHand />}
      </StyledButton>
      {openDialog &&
        <Dialog onClose={() => setOpenDialog(false)}>
          {componentInsideModal}
        </Dialog>
      }}
    </>
  )
}

Note: The example above is a simplified version of a component that I've actually seen in production

โŒ View a not-so-good solution
const ShopCategoryTile = ({
  item,
  offers,
}: {
  item: ItemMap;
  offers?: Offer;
}) => {
  const dispatch = useDispatch();
  const location = useLocation();
  const history = useHistory();
  const { items } = useContext(OrderingFormContext)
  const [openDialog, setOpenDialog] = useState(false)
  const [hover, setHover] = useState(false)
  const isBooked =
    !item.disabled && !!items?.some((a: Item) => a.itemGroup === item.group)
  const isDisabled = item.disabled || !offers
  const RenderComponent = item.component

  useEffect(() => {
    if (openDialog && !location.pathname.includes("item")) {
      setOpenDialog(false)
    }
  }, [location.pathname]);
  const handleClose = useCallback(() => {
    setOpenDialog(false)
    history.goBack()
  }, [])

  return (
    <GridStyled
      xs={6}
      sm={3}
      md={2}
      item
      booked={isBooked}
      disabled={isDisabled}
    >
      <Tooltip
        title="Not available"
        placement="top"
        disableFocusListener={!isDisabled}
        disableHoverListener={!isDisabled}
        disableTouchListener={!isDisabled}
      >
        <PaperStyled
          disabled={isDisabled}
          elevation={isDisabled ? 0 : hover ? 6 : 2}
        >
          <Wrapper
            onClick={() => {
              if (isDisabled) {
                return;
              }
              dispatch(push(ORDER__PATH));
              setOpenDialog(true);
            }}
            disabled={isDisabled}
            onMouseEnter={() => !isDisabled && setHover(true)}
            onMouseLeave={() => !isDisabled && setHover(false)}
          >
            {item.icon}
            <Typography variant="button">{item.label}</Typography>
            <CheckIconWrapper>
              {isBooked && <FaCheckCircle size="26" />}
            </CheckIconWrapper>
          </Wrapper>
        </PaperStyled>
      </Tooltip>
      <Dialog fullScreen open={openDialog} onClose={handleClose}>
        {RenderComponent && (
          <RenderComponent item={item} offer={offers} onClose={handleClose} />
        )}
      </Dialog>
    </GridStyled>
  )
}

๐Ÿ’– 2.4 Duplication is far cheaper than the wrong abstraction

Avoid premature / inappropriate generalization. If your implementation for a simple feature requires a huge overhead, consider other options. I highly recommend reading Sandi Metz: The Wrong Abstraction.

A particular type of complexity is over-engineering, where developers have made the code more generic than it needs to be, or added functionality that isnโ€™t presently needed by the system. Encourage developers to solve the problem they know needs to be solved now, not the problem that the developer speculates might need to be solved in the future. The future problem should be solved once it arrives and you can see its actual shape and requirements in the physical universe. - Google Engineering Practices: What to look for in a code review

See also: KCD: AHA Programming, C2 Wiki: Contrived Interfaces/The Expensive Setup Smell/Premature Generalization

๐Ÿง˜ 3. Performance tips

Premature optimization is the root of all evil - Tony Hoare

One accurate measurement is worth a thousand expert opinions. - Grace Hopper

TL;DR

  1. If you think itโ€™s slow, prove it with a benchmark. "In the face of ambiguity, refuse the temptation to guess." The profiler of React Developer Tools (Chrome extension) is your friend!
  2. Use useMemo mostly just for expensive calculations
  3. If you're going to use React.memo, useMemo, and useCallback for reducing re-renders, they shouldn't have many dependencies and the dependencies should be mostly primitive types.
  4. Make sure your React.memo, useCallback or useMemo is doing what you think it's doing (is it really preventing rerendering? Can you demonstrate empirically that using them on your case has significant performance gains? Memoization can sometimes make your app worse, so keep an eye on that!)
  5. Stop punching yourself every time you blink (fix slow renders before fixing rerenders)
  6. Putting your state as close as possible to where it's being used will not only make your code so much easier to read but it would also make your app faster (state colocation)
  7. Context should be logically separated, do not add too many values in one context provider. If any of the values of your context changes, all components consuming that context also rerenders even if those components don't use the specific value that was actually changed.
  8. You can optimize context by separating the state and the dispatch function
  9. Know the terms lazy loading and bundle/code splitting
  10. Window large lists (with tannerlinsley/react-virtual or similar)
  11. A smaller bundle size usually also means a faster app. You can visualize the code bundles you've generated with tools such as source-map-explorer or @next/bundle-analyzer (for NextJS).
  12. If you're going to use a package for your forms, I recommend react-hook-forms. I think it is a great balance of good performance and good developer experience.
View selected KCD articles about performance

๐Ÿง˜ 4. Testing principles

Write tests. Not too many. Mostly integration. - Guillermo Rauch

TL;DR

  1. Your tests should always resemble the way your software is used
  2. Make sure that you're not testing implementation details - things which users do not use, see, or even know about
  3. If your tests don't make you confident that you didn't break anything, then they didn't do their (one and only) job
  4. You'll know you implemented correct tests when you rarely have to change tests when you refactor code given the same user behavior
  5. For the front-end, you don't need 100% code coverage, about 70% is probably good enough. Tests should make you more productive not slow you down. Maintaining tests can slow you down. You get diminishing returns on adding more tests after a certain point
  6. I like using Jest, React testing library, Cypress, and Mock service worker
View selected KCD articles about testing

๐Ÿง˜ 5. Insights shared by others

If you'd like to share some of the things you think about when you write React code that I didn't touch upon, you can submit a PR and add them to this section. Thanks for taking the time to share your ideas!

Josh W Comeau

A similar principle I feel much more strongly about is not to pass setters that have too much power. For example, I might pass an updateEmail function instead of a setUser function. I don't want random components to be able to change things they don't have any business changing.

Not only should a component have a single responsibility, it should also have a clear spot on the spectrum of abstraction. On one end, we have generic building blocks like <Button>, <Heading>, <Modal>. On the other end, we have one-off templates like <Homepage> and <ContactForm>. Every component should have a clear spot on this spectrum. A <Button> component shoudn't have a user prop, since users are a higher-abstract concept and Button is a low-abstract component.

(Note, the above is taken from his response to my email... I really appreciate that he took the time to share his ideas ๐Ÿ™‚)

More Repositories

1

robotics-coursework

๐Ÿค– Places where you can learn robotics (and stuff like that) online ๐Ÿค–
2,605
star
2

hexapod-robot-simulator

A hexapod robot simulator built from first principles
Python
768
star
3

hexapod

Blazing fast hexapod robot simulator for the web.
JavaScript
579
star
4

fusion-ukf

An unscented Kalman Filter implementation for fusing lidar and radar sensor measurements.
C++
278
star
5

epic-react-exercises

Practical React exercises with detailed solutions.
JavaScript
159
star
6

mpc

A software pipeline using the Model Predictive Control method to drive a car around a virtual track.
C++
154
star
7

rusty-genes

Genetic algorithm implementation in Rust with animated visualizations in Python
Rust
141
star
8

fusion-ekf

An extended Kalman Filter implementation in C++ for fusing lidar and radar sensor measurements.
C++
135
star
9

cpp-resources

A small collection of notes about basic C++
C++
132
star
10

hexy

Code for a hexapod robot
Python
85
star
11

vehicle-tracking-2

A vehicle detection and tracking pipeline with OpenCV, histogram of oriented gradients (HOG), and support vector machines (SVM).
Jupyter Notebook
84
star
12

advanced-lane-detection

An advanced lane-finding algorithm using distortion correction, image rectification, color transforms, and gradient thresholding.
Jupyter Notebook
80
star
13

algorithm-playground

An (old) and unstructured (messy tbh) collection of programming exercises.
Jupyter Notebook
79
star
14

hexapod-irl

A "fork" of Bare-Minimum Hexapod Robot Simulator 2 modified to be able to control a real physical hexapod robot.
JavaScript
72
star
15

point-cloud-clusters

A catkin workspace in ROS which uses DBSCAN to identify which points in a point cloud belong to the same object.
Python
63
star
16

fusion-ekf-python

An extended Kalman Filter implementation in Python for fusing lidar and radar sensor measurements
Jupyter Notebook
63
star
17

arm-ik

An Inverse Kinematics 6DOF Robot Arm Pick and Place Project in ROS.
Jupyter Notebook
62
star
18

simple-cryptography

Scripts that illustrate basic cryptography concepts based on Coursera Standford Cryptography I course and more.
Python
60
star
19

hello-3d-world

Plot 3d points, lines, and polygon on an svg. A demonstration of what you can do with the BareMinimum3d package
TypeScript
57
star
20

point-cloud-filter

Scripts showcasing filtering techniques applied to point cloud data.
Python
49
star
21

particle-filter-prototype

Particle Filter Implementations in Python and C++, with lecture notes and visualizations
Jupyter Notebook
43
star
22

highway-path-planning

My path-planning pipeline to navigate a car safely around a virtual highway with other traffic.
C++
40
star
23

hexapod-kinematics-library

Code you can use to solve forward / inverse kinematics and generate walk sequences of hexapod robots
JavaScript
39
star
24

bare-minimum-3d

A small package to transform declared 3d data (points, polygons, lines) to 2d data.
TypeScript
33
star
25

arduino-basic

Code for an Arduino Boot Camp with emphasis on ditching delay(), basic object-oriented programming, and clean readable code.
C++
30
star
26

semantic-segmentation

A Fully Convolutional Network (FCN) script to label the pixels of a road in images
Jupyter Notebook
27
star
27

deep-blueberry

If you've always wanted to learn about deep-learning but don't know where to start, then you might have stumbled upon the right place!
25
star
28

crypto

Is Bitcoin cloud mining profitable? Check the notebook to find out! (Not Clickbait)
Jupyter Notebook
24
star
29

bare-minimum-2d

An extremely lightweight React component to declaratively (and elegantly) plot shapes on an inline SVG
JavaScript
23
star
30

hello-tiny-box

๐Ÿ“ฆ Manipulate a three dimensional box ๐Ÿ“ฆ
JavaScript
20
star
31

hellobot-raspberry

Code for various mobile robotics projects
C++
18
star
32

digital-garden

๐ŸŒฑ๐ŸŒทMithi's digital garden built with NextJS
TypeScript
16
star
33

traffic-signs-classification

A deep neural network to classify traffic signs, using TensorFlow.
Jupyter Notebook
15
star
34

some-udacity-projects

Some of my projects as a former mentor, reviewer, and beta-tester of Robotics and Self-Driving Car ND
Jupyter Notebook
15
star
35

bossy

๐ŸŽฎ Contains the code that can be used with Bossy controllers and derivatives ๐ŸŽฎ
C++
10
star
36

kingdom-rush-graphql

Simply get Kingdom Rush Tower information through queries in GraphQL
TypeScript
10
star
37

coding-exercises

Coding exercises for fun and profit
JavaScript
8
star
38

beginning-japanese

Self-study plan for learning japanese tailored to me
7
star
39

sdc-talk

A workshop about a problem-solving philosophy, machine learning intuitions, and behavioral cloning in the context of DIY self-driving / self-racing cars.
6
star
40

robotics-blog

My robotics blog
HTML
5
star
41

mithi

My github profile readme
5
star
42

hotels

TypeScript
3
star
43

portal-clone

TypeScript
2
star
44

wordpress-archive

Articles I wrote about hexapod robots and the lego technic 4x4 crawler
2
star